Renamed CDP env vars to modern convention #732
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Heimdall Review Status
|
github-actions
bot
added
documentation
2 tasks
CarsonRoscoe
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
CDP Env var naming has changed from v1 to v2 in the CDP SDK. As we're moving the repo over to using the latest version, we are also updating all the env var naming conventions along the way.
tl;dr:
CDP_API_KEY_NAME->CDP_API_KEY_IDandCDP_API_KEY_PRIVATE_KEY->CDP_API_KEY_SECRETTests
Testing by randomly selecting CDP examples in both Typescript and Python to run, and confirming they are all running as expected.
Note
This knowingly breaks the
nextandmcptemplates in thecreate-onchain-agentCLI locally. They will automatically be fixed once we do our next release on Friday. In the meantime, we are ignoring these templates from the turborepo so that it does not trip up our github actions.(The break is that they rely on the new interface, but they install from the npm registry, so until the release is out, they are trying to use an interface that is not yet available)
Checklist